Add missing checkout step to github-release job - #146
Merged
Merged
Conversation
gh release create --verify-tag needs a local git checkout to verify the tag against; the job never had one, so it would fail on any run, not just the reuse_run_id retry path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release create --verify-tagrequires a local git checkout to verify the tag against, but thegithub-releasejob never checked out the repo, so it fails withfatal: not a git repository.actions/checkoutstep before the release-creation step, matching what was tested when finishing the 1.8.0 release.Test plan
reuse_run_idfor 1.8.0 and confirmgithub-releasesucceeds.