Repository navigation
[Perf] Report every 10 seconds by default - #33
Merged
Merged
Conversation
Members reported every 30 seconds. Signal-based shortages (latency, saturation) were seen up to 30 seconds late, and since the hub moves traffic a step only once both members have reported after the last step, traffic moved about a step every 30 seconds whatever cooldown said. In the AWS comparison a queue-based controller with a 10-second loop recovered sooner where a ready replica was waiting in the other cluster. The default `--interval` (Helm `agent.interval`) is now 10 seconds, as the hub's. The wait for fresh reports stays; members just report more often. Each report runs the policy's Prometheus queries and writes its status once. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Jungwoo Song <bluayer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Members reported every 30 seconds, and two things followed from that:
cooldownsaid.In the AWS comparison, a queue-based controller with a 10-second loop recovered sooner where a ready replica was waiting in the other cluster.
Change
--interval(Helmagent.interval) goes from 30s to 10s, the same as the hub's.docs/configuration.md(chart value and flag rows; the value row now explains that it paces traffic steps) and the comment invalues.yaml.Not a duplicate
This came from comparing reaction times with the experiment's queue-based controller. No issue or PR covers it.
How it was tested
go test ./cmd/... ./internal/controller/passes,make lintreports 0 issues, andmake chartpasses.Checklist
make test lint verify-generate verify-modpassesgit commit -s, DCO)Co-authored-by: Claudetrailer.shadowmode first, and hub decisions are recorded in the decision log (default change only)docs/, chart values, CRD field comments)🤖 Generated with Claude Code