[matt2e]

Summary

On the Agents page, choosing another agent or closing the agent panel used to drop unsaved edits without asking. It now uses the same "Discard changes?" prompt the pane already shows when you switch section tabs. The prompt reads "Your unsaved changes to {name} will be lost." and offers Keep editing and Discard changes.

• What asks: these all ask first:

  • in the grid: a card click, the arrow keys, Home and End, Escape, or a second click on the open card
  • a card's Open settings
  • finishing Create
  • marketplace Open and Explore
  • closing the panel with the tab ×, Escape in the panel, or the native close-tab command

  Unsaved section drafts, a staged harness change and an unsaved header name all count.

• Focus follows the answer: Keep editing returns focus to the card that is still selected. Discard changes moves it to the card you chose, or to the card that closed. A declined × no longer pulls focus into the panel, because a PanelWorkspace item's close may now return false to keep its tab.

• Delete: deleting an agent closes only its own panel, without asking. Deleting a different agent no longer closes the open one.

• Import an agent: Import opens as a dialog over the page, so the open agent and its draft stay, without asking.

• While a save is pending: the selection doesn't change. The grid is marked aria-busy, and the other cards dim (0.5 opacity, progress cursor), as the panel's other section tabs grey out.

Pattern matched

The main model is the Agents pane's own section-switch prompt in AgentTabs. Its alert and reporting hook moved into DiscardChanges and useAgentSaveReports in src/features/agents/AgentSaveButton.tsx, so both prompts render the same component and differ only in their description.

The close guard in Settings → Profile ("Discard changes? Your profile has unsaved changes.") also follows this pattern. I didn't use ChannelDetailsEditor or WorkflowChannel as models: they confirm inside their own dialogs, which doesn't fit a side panel. docs/agents.md describes the new behavior.

Tests

AgentsPage.test.tsx adds 11 cases:

• switching away from a draft, then Keep editing or Discard changes
• closing with a draft, and a different agent's deletion leaving that draft open
• an unsaved name, with the selection held while it saves
• a staged harness change
• Create and a card's Open settings over a draft
• marketplace Open over a draft, with either answer
• Import keeping the draft, and deleting the open agent closing it without asking
• grid focus after a click, a second click, Escape and the arrow keys, for both answers
• a list that reorders behind the prompt
• an unfinished agent's Delete finishing after a link opened another agent

PanelWorkspace.test.tsx covers native close falling back from the main conversation to a side tab that declines.

These checks passed before the branch was rebased onto current main: biome, lint, typecheck, design checks, the agents, panels and profiles suites, and every PanelWorkspace consumer. They haven't been re-run since the rebase. The patches are unchanged.

Known gap

Links, toasts and Back/Forward can still change the selection without asking, under the navigation-history contract.

Scope

This fixes only the unsaved-edits half of "Agents page: switching agents or closing the panel drops unsaved edits, and approved agent requests show nothing; one PR each, and no open PR fixes either". The approved agent requests issue is not addressed here.

Before / after

Side by side, before on the left and after on the right. With Ada's edit unsaved, the recording clicks Bo, then × on Ada's panel tab. Before, both drop the edit. After, both ask first.

agents-unsaved-edits-before-after.mp4

Existing prompts this matches

Captured before the change:

🤖 Generated with Claude Code

[kazemek21]

Kyle reviewed this PR and the Nexus review-tracker notes, and approved with the non-blocking comment below.

Posted by Codex (gpt-6.1-sol) on behalf of kylez.