Skip to content

Guard onvif RelativeMove failures - #24835

Merged
NickM-27 merged 1 commit into
devfrom
guard-onvif
Oct 31, 2026
Merged

NickM-27 merged 1 commit into
devfrom
guard-onvif

Conversation

@hawkeye217

Copy link
Copy Markdown
Collaborator

Please read the contributing guidelines and the AI policy before submitting a PR. Every PR must be read and submitted by a person, and PRs that appear to be unreviewed AI output will be closed without review.

Proposed change

This PR adds a try/except around ONVIF RelativeMove, the same way _move already does for ContinuousMove, so that a failed call doesn't take down ONVIF until restart.

  • Add test

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

For new features

  • There is an existing feature request or discussion with community interest for this change.
    • Link:

AI disclosure

  • No AI tools were used in this PR.
  • AI tools were used in this PR. Details below:

AI tool(s) used (e.g., Claude, Copilot, ChatGPT, Cursor):

How AI was used (e.g., code generation, code review, debugging, documentation):

Extent of AI involvement (e.g., generated entire implementation, assisted with specific functions, suggested fixes):

Human oversight: Describe what manual review, testing, and validation you performed on the AI-generated portions.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I can explain every line of code in this PR if asked.
  • UI changes including text have used i18n keys and have been added to the en locale.
  • The code has been formatted using Ruff (ruff format frigate)

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects ONVIF relative moves and the autotracking queue that awaits them.

Calibration must distinguish failed moves before this PR is safe to merge.

Findings

  1. P1 Failed moves skew saved estimates ▶

Summary

This PR catches RelativeMove errors so a failed request no longer ends the autotracking move queue.

  • Failed ONVIF relative moves are logged without escaping the move handler.

Reviews (1) · Last reviewed commit: "guard relativemove failures" · Reviewed by Greptile

Comment thread frigate/ptz/onvif.py Resolved
@NickM-27
NickM-27 merged commit a0b8d40 into dev Oct 31, 2026
11 checks passed
@NickM-27
NickM-27 deleted the guard-onvif branch October 31, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants