Repository navigation
Conversation
…into msynk/13907-blazorui-trimming-issues-in-client-server-projects
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe publish pipeline now rewrites Blazor Web App service-worker manifests after asset trimming, updates matching service-worker script versions, and replaces stale static assets. New tests cover hosted and standalone publish scenarios. ChangesService-worker manifest trimming
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant PublishTargets
participant UpdateTask
participant ManifestUtility
participant StaticWebAssets
PublishTargets->>UpdateTask: pass current, dropped, and trimmed assets
UpdateTask->>ManifestUtility: remove dropped URLs and update hashes
ManifestUtility-->>UpdateTask: return rewritten manifest and version
UpdateTask->>StaticWebAssets: write changed manifest and script candidates
UpdateTask-->>PublishTargets: return candidate and stale assets
PublishTargets->>StaticWebAssets: replace stale assets and define rewritten endpoints
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 65.22% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 12 files. (9 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: fixing BlazorUI asset-trimming issues in client-server projects. It is related to the service-worker manifest rewrite implemented by the pull request. Linked Issues check Issue #13907requires a Blazor Web App publish to update its client service-worker manifest after server-side trimming.UpdateBitBlazorUIServiceWorkerand the MSBuild targets perform this update. `S…Out of Scope Changes check The implementation, MSBuild integration, documentation, hosted test projects, manifest tests, endpoint checks, and compression checks support issue #13907. The tests verify the published files, hashes…Full details: Linked Issues check
-
Explanation
Issue
#13907requires a Blazor Web App publish to update its client service-worker manifest after server-side trimming.UpdateBitBlazorUIServiceWorkerand the MSBuild targets perform this update.ServiceWorkerManifestremoves URLs for omitted assets, applies hashes for retained trimmed assets, recalculates the manifest version, and updates the service-worker version marker. The hosted trimming tests verify dropped entries, replacement hashes, served-file coverage, and standalone behavior. The standalone client is not rewritten when its SDK-generated manifest already reflects trimmed files.
Full details: Out of Scope Changes check
-
Explanation
The implementation, MSBuild integration, documentation, hosted test projects, manifest tests, endpoint checks, and compression checks support issue
#13907. The tests verify the published files, hashes, service-worker entries, version updates, and endpoint metadata affected by the trimming rewrite. No unrelated change is demonstrated.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 65.22% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 12 files. (9 skipped: 9 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the asset list,
And trims the URLs that should not persist.
New hashes settle into place,
A fresh version marks their case.
The service worker hops along,
With matching files in its song.
Comment @coderabbitai help to get the list of available commands.
1 participant
closes #13907
Summary by CodeRabbit