Skip to content

Add missing public css var for ok and cancel buttons of BitDialog (#13656) - #13776

Open
msynk wants to merge 2 commits into
developfrom
msynk/13656-blazorui-dialog-public-css-var-ok-cancel
Open

msynk wants to merge 2 commits into
developfrom
msynk/13656-blazorui-dialog-public-css-var-ok-cancel

Conversation

@msynk

@msynk msynk commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

closes #13656

Summary by CodeRabbit

  • New Features
    • Added CSS variables for customizing dialog Ok and Cancel button backgrounds, text, borders, hover and active states, and corner radii.
    • Dialog button colors can follow the configured dialog color or use the primary color when no explicit color is set. Focus-ring colors follow the same fallback behavior.
  • Documentation
    • Clarified how explicit dialog colors and button CSS variables interact, including their defaults and fallback behavior.

@msynk
msynk requested a review from yasmoradi as a code owner October 11, 2026 14:48
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e6802cd9-f3f5-427a-93a4-55d053dcb680

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4558549c-ab65-4c63-a3e2-1061e73c59b8

📥 Commits

Reviewing files that changed from the base of the PR and between e09d4d2 and 1131d80.


📒 Files selected for processing (4)
  • src/BlazorUI/Bit.BlazorUI/Components/Surfaces/Dialog/BitDialog.razor.cs
  • src/BlazorUI/Bit.BlazorUI/Components/Surfaces/Dialog/BitDialog.scss
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Surfaces/Dialog/BitDialogDemo.razor.cs
  • src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Surfaces/Dialog/BitDialogStylesheetTests.cs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



Walkthrough

BitDialog adds public CSS variables for Ok and Cancel button styling, with fallback rules for button states and explicit dialog colors. The component and demo documentation describe the precedence rules. Stylesheet tests check the root resets and button fallbacks.

Changes

Dialog action-button styling

Layer / File(s) Summary
Button variables and fallback rules
src/BlazorUI/Bit.BlazorUI/Components/Surfaces/Dialog/BitDialog.scss, src/BlazorUI/Bit.BlazorUI/Components/Surfaces/Dialog/BitDialog.razor.cs, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Surfaces/Dialog/BitDialogDemo.razor.cs, src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Surfaces/Dialog/BitDialogStylesheetTests.cs
The stylesheet adds public variables and fallback rules for Ok and Cancel button colors, borders, backgrounds, radii, hover, and active states. Component and demo documentation describe how explicit Color interacts with these variables. Stylesheet tests check role-color resets and button fallback rules.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Feature · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 1131d

The public styling controls appear to work for both buttons, and no issue requiring a fix before merge remains.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: adding public CSS variables for the BitDialog OK and Cancel buttons.
Linked Issues check Passed Issue #13656 requires public controls for both BitDialog action buttons, including rest, hover, and active states, plus documentation. BitDialog.scss documents public --bit-Dialog-ok-button-* and …
Out of Scope Changes check Passed The reviewed changes support issue #13656. The SCSS changes implement the public button variables and their precedence and state behavior. The demo changes document the controls. The stylesheet tests …

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)


✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the dialog glow,
And finds new colors buttons know.
The Ok button gets a shade,
The Cancel button joins the parade.
Each state has fallback rules in tow.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BitDialog: no public variable or parameter restyles the OK and Cancel buttons

1 participant