Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,22 @@ well as test out the patch set and opine on the technical merits of the patch.
PR should be reviewed first on the conceptual level before focusing on code
style or grammar fixes.

To merge a PR we require all CI tests to pass, the PR has at least one approving review by a maintainer with write access, and reasonable criticisms have been addressed.
Repository maintainers
----------------------

Like all open source projects our maintainers are busy. Please take it easy on
them and only ping them if you get no response for a week or two. Maintainers must ensure
that there is "rough consenus" that a PR is needed and correctly implemented.
Maintainers are not required to review and test your PR. A maintainer may ACK and
merge (or NACK and close) a PR based on the reviews of any competent project contributors.

Minimum pull request merge requirements:

- all CI tests pass.
- at least two "accepts"/ACK from a repository maintainer (other than the author).
- no reasonable "rejects"/NACK from anybody who reviewed the code.

See the .github/CODEOWNERS file for a current list of the project maintainers.

Coding Conventions
------------------
Expand Down