Repository navigation
fix: Update syn to version 3, attribute-derive to 0.11 - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Dependency upgrades are covered by passing workspace tests with no source-code changes.
Pull request overview
Updates workspace procedural-macro dependencies from syn 2 to 3 and attribute-derive 0.10 to 0.11.
Changes:
- Upgraded
synto 3. - Upgraded
attribute-deriveto 0.11.
File summaries
| File | Description |
|---|---|
Cargo.toml |
Updates centralized workspace dependency versions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated get-size-derive2 version to 0.11.0 and removed duplicate entry.
bircni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we can upgrade the
synandattribute-derivedependencies simultaneously without any source-code changes. At least,cargo test --workspace --all-featuresstill passes. It wouldn’t hurt for someone actually familiar with the code to look over https://github.com/dtolnay/syn/releases/tag/3.0.0 for any pitfalls.