Repository navigation
Only register htmx.live JS API if the extension registers successfully - #4207
Open
scrhartley wants to merge 1 commit into
Open
scrhartley wants to merge 1 commit into
scrhartley wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is confusing that
htmx.liveis available when the extension has not registered successfully.I'm not aware that it's a desirable feature to only have the JS API available.
Corresponding issue: #4205
Testing
Tested manually using example from the corresponding issue.
Behavior is as expected for both when
htmx.config.extensionsis and is not in effect.Change is simple enough that regressions are unlikely (call to
initis part ofhtmx.registerExtension).Checklist
fourfor website changes,four-devforsource changes)
approved via an issue
npm run test) and verified that it succeeded