Repository navigation
Conversation
jay23606
force-pushed
the
fix-ignore-removed-target-response
branch
from
October 20, 2026 15:17
1084d56 to
3bf49e5
Compare
Collaborator
|
closing as i've merged my own fix for this now thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request target is removed while its request is pending, the eventual response should not affect the current page. At present, htmx can still process its title and
hx-headchanges even though the target is detached.Record whether the target is connected when the request starts, then discard the response if that target was removed before the response arrives. The guard runs before
htmx:before:response, preventing response extensions from applying stale page-level effects while preserving requests that begin with a detached target.Fixes #4101.
Validation:
npm run test:chrome -- --files test/tests/unit/ajax.js(29 passed, 0 failed, 1 skipped).