Repository navigation
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Nov 1, 2026
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
This is a lot less complex and more reliable: good!
JMS55
approved these changes
Nov 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
AutoExposurefrom a camera leaves the auto-exposure effect still applied.Solution
RemovedComponents); consequently, the lookup fails, and the buffer persists.RenderEntity. Only removals were missing the necessary ID translation.AutoExposurecomponent (checked via a view query).SyncComponentPluginalready removes the component from the render entity.Testing
mainbranch.AutoExposureto an HDR camera, then remove it during runtime.AI Disclosure
The AI found the root cause within the Bevy source code and wrote a patch, which I validated in my own engine and reviewed, while ensuring I fully grasped all the implications.