Fix priority bug with taskwarrior<->caldav tool

syncall/caldav/caldav_side.py

@@ -75,8 +75,12 @@ def get_all_items(self, **kargs):
 
         # Format & cache items from ics files
         for t in raw_todos:
-            data = icalendar_component(t)
-            item = map_ics_to_item(data)
+            try:
+                data = icalendar_component(t)
+                item = map_ics_to_item(data)
+            except Exception as err:  # noqa: BLE001
+                logger.warning(f"Skipping unparsable calendar object (url={t.url}: {err})")
+                continue
             todos.append(item)
             self._items_cache[item["id"]] = item
 
@@ -110,6 +114,25 @@ def delete_single_item(self, item_id: ID):
         if todo is not None:
             todo.delete()
 
+    def _update_todo_changes(self, todo, **changes):
+        def set_(key: str, val: Any):  # noqa: ANN401
+            icalendar_component(todo)[key] = val
+
+        for key, value in changes.items():
+            if key == "status":
+                set_(key, vText(value.upper()))
+            elif key in ["due", "created", "last-modified"]:
+                set_(key, vDatetime(value))
+            elif key == "priority":
+                if value:
+                    set_(key, vText(value))
+                else:
+                    icalendar_component(todo).pop("priority", None)
+            elif key in ["description", "summary"]:
+                set_(key, vText(value))
+            elif key == "categories":
+                set_(key, vCategory([vText(cat) for cat in value]))
+
     def update_item(self, item_id: ID, **changes):
         todo = self._find_todo_by_id_raw(item_id=item_id)
         if todo is None:
@@ -120,22 +143,11 @@ def update_item(self, item_id: ID, **changes):
             logger.opt(lazy=True).debug(f"Can't update item {item_id}\n\nchanges: {changes}")
             return
 
-        def set_(key: str, val: Any):  # noqa: ANN401
-            icalendar_component(todo)[key] = val
-
         # pop the key:value (s) that we're intending to potentially update
         for key in self._identical_comparison_keys:
             icalendar_component(todo).pop(key)
 
-        for key, value in changes.items():
-            if key == "status":
-                set_(key, vText(value.upper()))
-            if key in ["due", "created", "last-modified"]:
-                set_(key, vDatetime(value))
-            if key in ["priority", "description", "summary"]:
-                set_(key, vText(value))
-            if key == "categories":
-                set_(key, vCategory([vText(cat) for cat in value]))
+        self._update_todo_changes(todo, **changes)
 
         todo.save()
 

syncall/tw_caldav_utils.py

@@ -92,7 +92,7 @@ def convert_tw_to_caldav(tw_item: Item) -> Item:
     if "priority" in tw_item:
         caldav_item["priority"] = aliases_tw_caldav_priority[tw_item["priority"].lower()]
     else:
-        caldav_item["priority"] = ""
+        caldav_item["priority"] = None
 
     # Timestamps
     if "entry" in tw_item: