Conversation
The Monitoring section documented `MYSQL_ENABLE_LOGGING`, but the code reads `ENABLE_LOGGING` (src/utils/index.ts:5). Setting the documented name has no effect, so logging silently stays off. `MYSQL_LOG_LEVEL` and `MYSQL_METRICS_ENABLED` are not read anywhere in the source either, so they are removed rather than renamed. Also corrects the description: the flag gates diagnostic logging (startup, pool creation, connection acquire/release, errors), not query logging — the SQL text is never logged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Monitoring section of
docs/CONFIGURATION.mddocumentsMYSQL_ENABLE_LOGGING, but the code readsENABLE_LOGGING:Setting the documented name has no effect — logging silently stays off. Both
.env.distandRELEASE.mdalready useENABLE_LOGGING, so this docs page was the only place carrying the wrong name.Changes
MYSQL_ENABLE_LOGGING→ENABLE_LOGGING, in both the Monitoring table and the Advanced Config ExampleMYSQL_LOG_LEVELandMYSQL_METRICS_ENABLED— neither appears anywhere in the source, so they are documented but unimplementedENABLE_LOGGING=yeswould silently do nothingVerification
Same for
MYSQL_LOG_LEVELandMYSQL_METRICS_ENABLED.Not addressed here
MYSQL_POOL_SIZE,MYSQL_QUERY_TIMEOUT,MYSQL_CACHE_TTLandMYSQL_RATE_LIMITalso appear in the Advanced Config Example but have no source references either. Left alone to keep this diff focused — happy to follow up if you want them cleaned out too. (Pool size in particular is hardcoded to 10 atsrc/config/index.ts:224.)🤖 Generated with Claude Code