Repository navigation
Conversation
Hello and thank you for the package. When first trying to use it, I just asked an LLM to build me an XPath to search for what I wanted, it gave me something like this `//[starts-with(@id, 'replace')]` When it returned no elements, I thought that I had done something wrong, actually reading the documentation learned that the function is not supported, but then `etree.MustCompilePath` did not panic when I ran my program. I actually do not know enough about XML and XPath, but the LLM tells me that tags cannot contain `, ) (`, so I just added a new check before defaulting to treating the filter as a tag. Added a test to check.
Owner
|
This package doesn't support the full XPath specification. It supports a smaller subset of the spec. See the documetation on etree's path syntax here. (Perhaps you can point the LLM at this documentation.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for the package.
When first trying to use it, I just asked an LLM to build me an XPath to search for what I wanted, it gave me something like this
//[starts-with(@id, 'replace')]When it returned no elements, I thought that I had done something wrong, actually reading the documentation learned that the function is not supported, but then
etree.MustCompilePathdid not panic when I ran my program.I actually do not know enough about XML and XPath, but the LLM tells me that tags cannot contain
, ) (, so I just added a new check before defaulting to treating the filter as a tag.Added a test to check.