Report the codepoints a label could not draw - #6
Merged
Conversation
A codepoint absent from the glyph atlas advances half an em and draws no ink. Labels come out blank where a chart's names are in a script the atlas has no glyphs for, and a host has no way to learn which characters it needs. Built.missing_glyphs holds them, deduplicated, beside missing_images. layoutText scans the run before the wrap drops any of it, so a label cut short for want of a glyph still asks for the glyph that lets it fit. build and the concat path both report the set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A codepoint absent from the glyph atlas advances half an em and draws no ink, so labels come out blank where a chart's names are in a script the atlas has no glyphs for. A host has no way to learn which characters it needs. CJK alone is around 20,000 glyphs, so preloading a script is not the answer either: the atlas caps out near 18,000 cells at 1024x16384.
Built.missing_glyphsholds them, deduplicated, besidemissing_images, andlayoutSymbolFeaturethreads the set the same way.layoutTextscans the run's codepoints before the wrap drops any of it, so a label cut short for want of a glyph still asks for the glyph that lets it fit. Bothbuildand the concat path report the set.Nothing here bakes or loads a glyph. A host reads the set, rasterizes those characters from whatever face its platform has for the script, and calls
addSdfSheetoraddRange.zig buildandzig build testpass. Spec conformance is 575/577, the same two output failures as the base.