Repository navigation
fix: upgrade webpack-dev-server to 5.2.5 to patch HMR WebSocket interception vulnerability - #550
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Upgrade webpack-dev-server to fix vulnerabilities
fix: upgrade webpack-dev-server to 5.2.5 to patch HMR WebSocket interception vulnerability
Jun 25, 2026
rogene-bcgov
approved these changes
Jun 25, 2026
rogene-bcgov
marked this pull request as ready for review
June 25, 2026 18:16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



webpack-dev-server <5.2.5 allows a broadly-scoped proxy (
/withws: true) to intercept the dev server's own HMR WebSocket, leaking browser cookies and Origin headers to the proxy backend while corrupting the HMR socket.Changes —
twm/application/lib/ol-mapbox-style-6.3.0/package.json— Bumped devDependencies to webpack 5-compatible versions:webpack-dev-server:^3.9.0→^5.2.5webpack:^4.41.3→^5.0.0(required peer for wds v5)webpack-cli:^3.3.10→^5.0.0html-webpack-plugin:^3.2.0→^5.5.0karma-webpack:^3.0.5→^5.0.0mini-css-extract-plugin:^0.4.5→^2.0.0Webpack configs (
webpack.config.examples.js,webpack.config.olms.js,test/karma.conf.js) — Removed webpack 4-onlynode: {fs: 'empty'}option, which is unsupported in webpack 5.package-lock.json— Regenerated; resolveswebpack-dev-serverto5.2.5.Thanks for the PR!
After merge, new images are deployed and promoted to DEV: