Skip to content

fix: upgrade webpack-dev-server to 5.2.5 to patch HMR WebSocket interception vulnerability - #550

Merged
rogene-bcgov merged 2 commits into
masterfrom
copilot/upgrade-webpack-dev-server
Jun 25, 2026
Merged

rogene-bcgov merged 2 commits into
masterfrom
copilot/upgrade-webpack-dev-server

Conversation

Copilot AI commented Jun 25, 2026 •

Copy link
Copy Markdown
Contributor

webpack-dev-server <5.2.5 allows a broadly-scoped proxy (/ with ws: true) to intercept the dev server's own HMR WebSocket, leaking browser cookies and Origin headers to the proxy backend while corrupting the HMR socket.

Changes — twm/application/lib/ol-mapbox-style-6.3.0/

package.json — Bumped devDependencies to webpack 5-compatible versions:

  • webpack-dev-server: ^3.9.0 → ^5.2.5
  • webpack: ^4.41.3 → ^5.0.0 (required peer for wds v5)
  • webpack-cli: ^3.3.10 → ^5.0.0
  • html-webpack-plugin: ^3.2.0 → ^5.5.0
  • karma-webpack: ^3.0.5 → ^5.0.0
  • mini-css-extract-plugin: ^0.4.5 → ^2.0.0

Webpack configs (webpack.config.examples.js, webpack.config.olms.js, test/karma.conf.js) — Removed webpack 4-only node: {fs: 'empty'} option, which is unsupported in webpack 5.

package-lock.json — Regenerated; resolves webpack-dev-server to 5.2.5.

Note: this is a vendored library consumed via its pre-built dist/olms.js; the webpack toolchain changes only affect local development of the library itself.


Thanks for the PR!

After merge, new images are deployed and promoted to DEV:

Copilot AI changed the title [WIP] Upgrade webpack-dev-server to fix vulnerabilities fix: upgrade webpack-dev-server to 5.2.5 to patch HMR WebSocket interception vulnerability Jun 25, 2026
Copilot AI requested a review from rogene-bcgov June 25, 2026 18:13
@rogene-bcgov
rogene-bcgov marked this pull request as ready for review June 25, 2026 18:16
@rogene-bcgov
rogene-bcgov merged commit 2efb282 into master Jun 25, 2026
19 of 20 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants