Skip to content

fix: stop tracking packaging/ as a broken submodule gitlink - #40

Merged
juniorep merged 2 commits into
mainfrom
bbs-dev
Jul 27, 2026
Merged

fix: stop tracking packaging/ as a broken submodule gitlink#40
juniorep merged 2 commits into
mainfrom
bbs-dev

Conversation

@bbalouki

Copy link
Copy Markdown
Owner

Summary

packaging was recorded in git as a submodule reference (mode 160000) pointing to a commit with no corresponding .gitmodules entry and no matching repository, so GitHub rendered it as an unresolvable submodule link instead of a normal folder. Converting it to a plain tracked directory so its contents (the vcpkg port files) show up and are versioned normally on GitHub.

Type of change

  • Bug fix
  • [] New feature
  • [] Breaking change (see CONTRIBUTING)
  • [] Documentation
  • [] Build / CI/tooling

Checklist

  • Code follows the style (snake_case, PascalCase types, m_ members, trailing return types, etc.).
  • clang-format and clang-tidy pass locally.
  • Tests were added or updated under tests/ and ctest passes.
  • Public API changes are documented with Doxygen /// comments.
  • CHANGELOG is updated under [Unreleased].
  • Breaking changes to headers, wire formats, itch-tool, or the Python API are called out explicitly above.

bbalouki added 2 commits July 27, 2026 10:40
packaging was recorded in git as a submodule reference (mode 160000)
pointing to a commit with no corresponding .gitmodules entry and no
matching repository, so GitHub rendered it as an unresolvable
submodule link instead of a normal folder. Converting it to a plain
tracked directory so its contents (the vcpkg port files) show up and
version normally on GitHub.
Now that packaging/bbalouki-itch/vcpkg.json is a normal tracked file
(no longer hidden inside the broken submodule gitlink), the action's
default '**/vcpkg.json' glob matches it too. That file is a vcpkg
*port* manifest with no builtin-baseline field, and the action stops
at the first match, so every job failed with "A Git commit id for
vcpkg's baseline was not found nor in vcpkg.json nor in
vcpkg-configuration.json". Pinning vcpkgJsonGlob to the root file
disambiguates it.
@bbalouki
bbalouki requested a review from juniorep July 27, 2026 09:51
@juniorep
juniorep merged commit 9403009 into main Jul 27, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants