Skip to content

[DO NOT MERGE] test: verify Codecov config takes effect#6054

Closed
jam-jee wants to merge 1 commit into
aws:masterfrom
jam-jee:test/codecov-verify-donotmerge
Closed

[DO NOT MERGE] test: verify Codecov config takes effect#6054
jam-jee wants to merge 1 commit into
aws:masterfrom
jam-jee:test/codecov-verify-donotmerge

Conversation

@jam-jee

@jam-jee jam-jee commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

⚠️ DO NOT MERGE — verification PR

This PR exists only to confirm that the merged codecov.yml (PR #6034) actually takes effect on a PR whose branch contains it. It makes a no-op docstring-only change in sagemaker.mlops to force a unit-test coverage upload so Codecov recomputes.

Recent PRs (#6041, #6051) still show the old ~90% test-inflated number because their branches were cut before codecov.yml merged and don't contain it. This branch is cut from current master (which has codecov.yml), so Codecov should now:

  • Exclude test files via the ignore: list (previously ~98% of measured files were test files).
  • Report product-only project coverage (~71%), not the old ~90%.
  • Apply the project floor 65% / patch 70% status targets.

Expected: codecov/project and codecov/patch reflect the corrected, product-only numbers.

Will be closed without merging once verified.

No-op docstring line in sagemaker.mlops to force a unit-test coverage
upload so we can confirm the merged codecov.yml takes effect:
- test files excluded from the report (ignore: list)
- product-only project coverage (~71%, not the old test-inflated ~90%)
- project floor 65% / patch 70% status targets

This branch is cut from current master (contains codecov.yml). Verification
only — not intended to merge.
@jam-jee

jam-jee commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator Author

Closing — superseded by #6055. This fork-based PR could not produce a Codecov report: the CodeBuild uploader gets no PR/branch context for fork PRs (pr=false, empty branch), so Codecov errored the upload (state=error, sessions=0). #6055 runs the same no-op change from a same-repo branch, which uploads with full context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant