fix(lambda-http): handle fallible response body errors - #1169
Open
IamPritamAcharya wants to merge 1 commit into
Open
fix(lambda-http): handle fallible response body errors#1169IamPritamAcharya wants to merge 1 commit into
IamPritamAcharya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
Closes #1165
✍️ Description of changes:
lambda_httpaccepts fallibleHttpBodyresponse bodies, but its buffered textand binary conversion paths called
expect()afterbody.collect().await.Normal body errors therefore caused an internal panic.
This change:
run,run_concurrent,runtime, andruntime_concurrenttolambda_runtimeas invocation diagnostics;IntoResponseis used directly;Adapter, which mustpreserve its handler error type;
IntoResponse,ResponseFuture,Adapter, andTransformResponsesignatures unchanged;conversion behavior;
cargo lambda watch#1051.Regression tests use a
StreamBodythat emits partial data and then returns anUnexpectedEof. Both text and binary paths are covered, along with propagationthrough the standard runtime adapter.
Validation performed:
cargo +nightly fmt --all -- --checkcargo +1.84.0 test --all-features --verbose --package lambda_httpcargo check --workspace --all-featurescargo test -p lambda_http --all-featurescargo test --workspace --all-features --exclude lambda-integration-testscargo clippy --workspace --all-features -- -D warningsRUSTDOCFLAGS='--cfg docsrs -Dwarnings' cargo +nightly doc --workspace --no-deps --document-private-items --all-featuresgit diff --checkThe deployment integration test requires an externally configured
TEST_ENDPOINTand was therefore not run successfully locally.🔏 By submitting this pull request
cargo +nightly fmt.