perf: avoid expensive call to Mac.getInstance - #2174
Open
mkeskells wants to merge 2 commits into
Open
Conversation
Author
|
I haven't changed the javadoc to match the implementation, as it seems that a first review is likely to have an opinion as to API changes |
mkeskells
force-pushed
the
reduce-getInstance
branch
from
December 18, 2025 16:32
71e89a8 to
909e2a9
Compare
Author
|
Hi |
|
I've approved the CI to run but looks like this is a breaking change. Let's wait for the CI results. |
Author
|
@ShubhamChaturvedi7 thanks. The CI failures loom to me to be unrelated to my change - failing in I had hoped that this would not be a breaking change. It only changes non public fields and internal classes, but I dont know the threshold for breaking changes for this library! Happy to work with you or someone else to lessen the breaks which reducing the CPU cost, Please advise of the best next steps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No Issue
Description of changes:
Minimal change to avoid calls to Mac.getInstance
Call to this were only used to extract the provider, which I though would be better expressed as an enum, as there are very few MacAlgorithms in use.
In my (closed source) benchmark this call accounts for 5.6% of the CPU time taken for a decryption (a call to
AwsCrypto.decryptData), with small payloads, and thee same for encryptionI cant fully build this locally so cant run a test cycle prior to submitting this PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: