Replace CleanroomLogger example with native os.Logger - #762
Merged
Conversation
CleanroomLogger was dropped as a dependency, leaving the example app's loggerOutput implementation and the Lock event callbacks in showLock entirely commented out (so lock.present(from:) was never even called). Rename CleanroomLockLogger to OSLockLogger, back it with os.Logger, and restore the onAuth/onError/onSignUp/onCancel/onPasswordless logging through the same native API. Also drops the now-orphaned CleanroomLogger.xcframework reference from the Xcode project and updates the logging section of EXAMPLES.md to match.
utkrishtsahu
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CleanroomLoggerwas dropped as a dependency a while back, leaving the example app'sloggerOutputimplementation and theLockevent callbacks inshowLockentirely commented out — meaninglock.present(from:)was never even called.CleanroomLockLoggertoOSLockLogger, backed by Apple's nativeos.Logger, and restores theonAuth/onError/onSignUp/onCancel/onPasswordlesslogging through the same native API.CleanroomLogger.xcframeworkreference from the Xcode project (it wasn't linked into any build phase).EXAMPLES.mdto match.Test plan
os.Logger/showLockcode against stub types mirroring Lock's real public API (Lock,LoggerOutput,LoggerLevel,Credentials) viaswiftc -typecheck.swiftlint lint App/ViewController.swiftexits 0 (only pre-existing, unrelated warnings).plutil -lint Lock.xcodeproj/project.pbxprojpasses.