docs(scripts): describe the recount connection string by role - #212
Merged
Conversation
The comment named one deployment's database. This repository is public, so an internal database name in it is infrastructure detail with no reader who benefits: the script takes whatever DATABASE_URL points at and its CONTRACT variable already carries the only value that has to match the data. Signed-off-by: Rob Konsdorf <rob@facings.io>
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change is accurate and removes unnecessary infrastructure detail.
Pull request overview
Clarifies recount-script documentation without changing behavior.
Changes:
- Replaces a deployment-specific database name with role-based guidance.
File summaries
| File | Description |
|---|---|
src/scripts/recount-asset-counts.ts |
Clarifies the DATABASE_URL comment. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DATABASE_URLcomment insrc/scripts/recount-asset-counts.tsnamed one deployment's database by name. This repository is public, so that is internal infrastructure detail sitting in it for no reader's benefit: the script recounts whateverDATABASE_URLpoints at, andCONTRACTalready carries the only value that has to match the data.Comment only. No behaviour changes and no other occurrence of the name exists under
src/ordefinitions/.Found while reviewing #203, which does not touch this file.