Feature/coverage - #6
Open
SukiCZ wants to merge 8 commits into
Open
Conversation
Coverage 79% > 95%
Coverage 95% > 96%
Coverage 96% > 97%
atbuy
self-requested a review
February 6, 2025 15:02
Owner
|
Looks good, nice idea to add tests for multiple pil versions, but I think the tests are badly written from the start. I'll try to rewrite them when I find the time. |
Contributor
Author
|
Do you have anything particular in mind? I think they are fine and we can iterate from here. Maybe |
Owner
|
@SukiCZ I was thinking more like tests using classes. I think they are more readable and more explicit. I'll probably have time tomorrow to implement them. I'll open a PR.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves coverage from 79% to 97%