Skip to content

show/hide tabular winners in JS, not Python - #574

Merged
artoonie merged 1 commit into
mainfrom
feature/dynamically-showhide-tabular-winners
Aug 28, 2025
Merged

artoonie merged 1 commit into
mainfrom
feature/dynamically-showhide-tabular-winners

Conversation

@artoonie

@artoonie artoonie commented Aug 28, 2025 •

Copy link
Copy Markdown
Owner

The ability to show only winners in the tabular option was presented as a GET setting (i.e. one that could be changed by an end-user, not an uploader), but in reality, it was done in Python and therefore only respected when selected by the uploader. This PR makes it happen dynamically instead.

Comment thread templates/tabular/tabular-by-candidate.html Fixed
@artoonie
artoonie force-pushed the feature/dynamically-showhide-tabular-winners branch from d95f7d3 to fa0ca88 Compare August 28, 2025 18:49
@artoonie
artoonie force-pushed the feature/dynamically-showhide-tabular-winners branch from fa0ca88 to 4ae3d68 Compare August 28, 2025 19:22
@codecov

codecov Bot commented Aug 28, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.02%. Comparing base (cbe468c) to head (4ae3d68).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   96.01%   96.02%           
=======================================
  Files         128      129    +1     
  Lines        6049     6037   -12     
=======================================
- Hits         5808     5797   -11     
+ Misses        241      240    -1     
Files with missing lines Coverage Δ
visualizer/graph/graphSummary.py 98.68% <100.00%> (ø)
...nfig_dousedescriptioninsteadoftimeline_and_more.py 100.00% <100.00%> (ø)
visualizer/tabular/tabular.py 99.46% <100.00%> (ø)
visualizer/tests/testLiveBrowserWithHead.py 98.75% <ø> (-0.12%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe468c...4ae3d68. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artoonie
artoonie merged commit ebce5ff into main Aug 28, 2025
8 checks passed
@artoonie
artoonie deleted the feature/dynamically-showhide-tabular-winners branch August 28, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants