refactor: decide about control sockets down the stack - #416
Merged
Conversation
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
muchzill4
marked this pull request as ready for review
August 20, 2026 07:59
muchzill4
force-pushed
the
implicit-control-sockets
branch
from
August 20, 2026 08:04
29bff16 to
4ac4b86
Compare
awphi
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We have this awkward situation where low level code supports opting in to using control sockets, while in reality we always use them unless the underlying OS/SSH doesn’t support it. This PR simplifies the code, to make that OS/SSH decision down. the stack, where the control sockets are used.
Changes
Checklist