cmd/atlas/docker: let Docker Engine allocate a free port - #3501
Open
giautm wants to merge 3 commits into
Open
Conversation
This reverts commit 3bf015b.
masseelch
approved these changes
May 14, 2025
Contributor
|
@masseelch, we still didn’t find why it’s not working on Windows. |
Contributor
Author
You may missed it, but I found. Please re-check messages in the thread. |
a8m
approved these changes
May 15, 2025
luantranminh
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed a case in which the port was free on the machine running atlas-cli but unavailable on the machine running the Docker engine. (remote docker engine via
DOCKER_HOST)Because the
freePort()function only able to checks free ports on the current machine.