Conversation
…ct repository The quick-start runs MinIO pinned to a November 2022 image from a project that is now archived. This adds an opt-in component that serves the artifact repository with MiniStack instead, leaving the MinIO path untouched. Refs argoproj#17030 Signed-off-by: Nahuel990 <nahuelnucera990@gmail.com>
Contributor
✅ PR readiness: all clearAll contributor-fixable checks are passing. A maintainer will take it from here — thanks! 🤖 Automated PR-readiness helper — it re-checks each time CI finishes. Unit/E2E test results are not covered here. Questions? See the contributing guide or ask a maintainer. |
… component Refs argoproj#17030 Signed-off-by: Nahuel990 <nahuelnucera990@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the pull request guide for details on each item.
make pre-commit -Bmake feature-new)Refs #17030
Motivation
The quick-start artifact repository runs MinIO pinned to
quay.io/minio/minio:RELEASE.2022-11-17T23-20-09Z. MinIO has since stopped publishing community edition images and theminio/miniorepository is archived, last pushed 2026-04-24. The pinned digest still resolves, so nothing is broken today, but there is no upstream path for a future CVE.Rather than change the default, this adds an opt-in alternative so the quick-start has a maintained option. MinIO stays exactly as it is.
Modifications
New component
manifests/components/ministack, following the shape ofcomponents/mysql:ministack-deployment.yamlandministack-service.yamlserve S3 on port 4566, with/_ministack/healthreadiness and liveness probes, and apostStarthook that createsmy-bucketthrough theawslocalwrapper bundled in the image. The hook retries because the port binds before startup finishes, and always exits 0 so a slow start cannot kill the container.$patch: deleteoverlays drop the MinIO Deployment and Service.artifact-repositories-configmap.yamlandoverlays/workflow-controller-configmap.yamlfromminio:9000toministack:4566.my-minio-credsecret is left alone, since those credentials work unchanged.New variant
manifests/quick-start/ministackcomposes../basewith the component. The image is pinned by digest, matching how MinIO is pinned..features/pending/ministack-quick-start-component.mddescribes the change for the release notes.go run ./hack/featuregen validatereports all feature documents valid.No generated manifests are included:
make manifestsshould be run by a maintainer if this variant is wanted indist.Verification
kubectl kustomize manifests/quick-start/ministackbuilds, and in the output the MinIO Deployment and Service are gone, nominio:9000reference remains, and all three artifact repository endpoints point atministack:4566.Against the pinned image directly:
postStartcommand createsmy-bucketand exits 0PutObject,GetObjectandListObjectsV2succeed with themy-minio-credcredentials using path style addressing/_ministack/healthreturns 200Deployed for real on kind v0.30.0,
kubectl apply --server-sideof the built variant into namespaceargo:ministack,workflow-controller,argo-serverandhttpbinall reach ready, and no MinIO Deployment or Service is createdpostStarthook createdmy-bucketin the clusterSucceeded, and Argo recorded the keysartifact-check-.../hello.tgzandartifact-check-.../main.logRegression check on the existing variants:
minimal,mysql,postgresandtelemetryall regenerate byte-identical to the committedmanifests/quick-start-*.yaml, so this change adds files without perturbing any existing output.I have not run
make pre-commit -B, which needs the full codegen toolchain, so that box stays unticked.Documentation
None yet. If maintainers want this variant documented, the natural place is the artifact repository page, and I am happy to add it in this PR.
AI
Claude (Anthropic) was used to draft the manifests, the commit message and this description. Every claim above was verified by me against the built output and a running container, as described in Verification.