This repository was archived by the owner on Sep 2, 2026. It is now read-only.
chore(deploy): drop the deploy job, keep the image build - #3204
Merged
Conversation
appwrite.io moved to the console release (appwrite/new) on 2026-08-31, and the website Deployment is being removed from the assets clusters, so the values file this job writes into no longer exists: appwrite-labs/cluster-configuration-generator#225 appwrite-labs/application-configuration#173 The job ran `yq -i '.global.image.tag = ...'` against assets/<env>/website/default.yaml and pushed straight to that repo's main. `yq -i` exits 1 on a missing path rather than creating a stub, so this would have failed loudly on the next published release -- and production.yml fires on `release: published`, which happens regularly. The build job is untouched: the image still builds and pushes to both ghcr and Docker Hub under the release tag, so nothing that may still consume appwrite/website is affected. Only the declarative-deploy half goes away. Also drops the five env keys the deploy job alone used (ENVIRONMENT, PROJECT, APPLICATION, DECLARATIVE_OWNER, DECLARATIVE_REPOSITORY). The build job reads only TAG, IMAGE_NAME and the two REGISTRY_* keys, all of which stay.
Appwrite WebsiteProject ID: Website (appwrite/website)Project ID: Tip JWT tokens let functions act on behalf of users while preserving their permissions |
loks0n
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appwrite.iomoved to the console release (appwrite/new, a.k.a. vibes) on 2026-08-31, and the website Deployment is now being removed from the assets clusters:assets/{staging,production}/website/The breakage
production.ymlandstaging.ymleach end in adeployjob that does:and pushes the result straight to
application-configurationmain. Once that file is gone the job fails — I verifiedyq -iexits 1 on a missing path rather than creating a stub, so this fails loudly rather than silently resurrecting a file.production.ymlfires onrelease: published, and this repo publishes releases regularly (2.11.437 on Aug 27), so the next release would hit it.What changes
deployjob from both workflowsENVIRONMENT,PROJECT,APPLICATION,DECLARATIVE_OWNER,DECLARATIVE_REPOSITORYThe build job is deliberately untouched. The image still builds and pushes to both ghcr.io and Docker Hub under the release tag, so anything that may still consume
appwrite/websitekeeps working — only the declarative-deploy half goes away. Dropping the build too would be the tidier end state if the image is genuinely unused, but I could not confirm that from the infrastructure repos, so this stops short of it.Verification
Both files parse as valid YAML with
jobs: ['build']and no danglingneeds; every survivingenv.Xreference still resolves to a defined key; noDECLARATIVE,yq -i,app-token, orapplication-configurationreferences remain anywhere in the repo.prettier --checkpasses on both files (my first pass left a stray trailing newline that broke it — fixed).