Skip to content

feat: support runReport.json summaries, depend on @moonrepo/* packages - #10

Merged
suin merged 8 commits into
appthrust:mainfrom
0xar-ds:main
Sep 11, 2025
Merged

suin merged 8 commits into
appthrust:mainfrom
0xar-ds:main

Conversation

@0xar-ds

@0xar-ds 0xar-ds commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

closes #8, #1

style and functionality remains 1:1 with current release, though https://github.com/appthrust/moon-ci-retrospect/compare/main...0xar-ds:moon-ci-retrospect:main?expand=1#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122L121-R143 outputs new badges according to match the latest type of ActionStatus

@0xar-ds

0xar-ds commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@suin @kahirokunn any chances this could have a merge?

@0xar-ds

0xar-ds commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

As this PR feats runtime dependencies, and most CI runners do not install dependencies prior to executing scripts, it is not ready for merge. I'll push a featuring of rollup in just a second.

@0xar-ds

0xar-ds commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@suin

suin commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for your PR. Could you check the CI result?

@0xar-ds

0xar-ds commented Sep 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Thank you for your PR. Could you check the CI result?

Well, that's because the snapshots are of my local machine & now they include tracing information of whether the action will summarize a ciReport or a runReport.

We can go two ways from here, up for you to choose:

a. Tests/CI workflow builds a snapshot of the program prior to testing against it
b. The path in the tracing information is expanded up to the workspace root, not the root of the filesystem.

I'd argue to go for A, which is my following commit. Let me know if you'd prefer the other option.

@suin

suin commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Thank you for checking the CI result.

I think option B is better than A, since that is testable and relative paths is conciser for users.

Could you fix it?

fix: @moonrepo/types is not a runtime dependency
chore: update tsconfig.json

chore: update release destination

chore: bump yarn lock
style: format file

chore: bump yarn lock
@0xar-ds

0xar-ds commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

@suin should be good to merge, tests are against the static snapshots present on the repository & it's passing on my branch

@suin
suin merged commit 2b2216c into appthrust:main Sep 11, 2025
1 check passed
@suin

suin commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Thank you! I've merged your great work.

@suin suin mentioned this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support runReport.json files as well

2 participants