Skip interactive prompts for database flags that are explicitly set - #162
Open
blsmth wants to merge 1 commit into
Open
Skip interactive prompts for database flags that are explicitly set#162blsmth wants to merge 1 commit into
blsmth wants to merge 1 commit into
Conversation
apppack create database always re-prompted for cluster, engine, aurora, instance-class, and multi-az even when those values were passed as flags, so --engine (and friends) were effectively ignored. Record which flags were explicitly set in UpdateFromFlags and skip the matching prompt in AskQuestions. The --engine flag now accepts the fully qualified name (mysql, postgres, aurora-mysql, aurora-postgresql) and bypasses both the engine and aurora prompts; the value is validated. Fixes #85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
apppack create databaseignored flags like--engine. Even when a flag was provided,AskQuestionsunconditionally re-prompted for cluster, engine, aurora, instance-class, and multi-az — the flag value was only used as the prompt default, so users still had to pick from a dropdown.Fixes #85.
Change
UpdateFromFlagsnow records which flags the user explicitly set (viaflags.Visit).AskQuestionsskips the prompt for any flag that was set.--engineaccepts the fully-qualified engine name (mysql,postgres,aurora-mysql,aurora-postgresql) and bypasses both the engine and aurora prompts. The value is validated so a typo fails fast instead of silently.--instance-classis provided, the RDSDescribeOrderableDBInstanceOptionsAPI call is skipped entirely (no prompt, no lookup).Flags left unset still prompt interactively exactly as before.
--non-interactiveis unaffected.Notes
The same 'flag ignored' pattern applies to other
createsubcommands (ipmb noted--cluster); this PR fixes the database command. Happy to follow up with the same treatment elsewhere if we like the approach.