Repository navigation
Incorrect error message for .allRemainingInput options without values - #1003
Open
james-fletcher-01 wants to merge 3 commits into
Open
james-fletcher-01 wants to merge 3 commits into
james-fletcher-01 wants to merge 3 commits into
Conversation
Issue apple#434 reported that when a label, but no values, are provided for an array @option property, the error message incorrectly signifies a missing option instead of a missing value. PR apple#435 fixed this for .upToNextOption arrays, but the bug remained for .allRemainingInput arrays. In addition to tests for verifying the error message, this also adds tests to verify that an attached value counts for the validation. This was a regression for .upToNextOption introduced in apple#435 and fixed in apple#610.
The previous commit was authored prior to the Swift Testing migration
This test originally expected the `.allRemainingInput` option to use the default value when specifying the option label without a value, but this is now an error instead. The test has been updated to expect the error.
james-fletcher-01
requested review from
natecook1000 and
rauhul
as code owners
November 9, 2026 01:16
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #750
Issue #434 reported that when a label, but no values, are provided for an array
@Optionproperty, the error message incorrectly signifies a missing option instead of a missing value. PR #435 fixed this for.upToNextOptionarrays, but the bug remained for.allRemainingInputarrays. This PR modifies the behaviour for.allRemainingInputto match that of.upToNextOption.The
parsing_repeatingStringRemaining_2test previously expected options with a default value to use the default value when an option label is provided without a value. This has been modified to expect an error, as per the discussion in #750.Checklist