Repository navigation
Stop collecting subcommand names into .allUnrecognized arguments - #1002
Open
aniketatgithub wants to merge 1 commit into
Open
aniketatgithub wants to merge 1 commit into
aniketatgithub wants to merge 1 commit into
Conversation
Signed-off-by: Aniket <aniketkomailkro@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #796
A parent command with
@Argument(parsing: .allUnrecognized)swallowed its subcommand names, so./App list 1ran the parent with["list", "1"]instead of dispatching to thelistsubcommand. A subcommand name is recognized input, not unrecognized input, soLenientParsernow stops collecting into the.allUnrecognizedargument at the first value matching a subcommand name (or the built-inhelpsubcommand), leaving it for subcommand dispatch. Values before the subcommand name still stay with the parent, and values after--are still treated as literal data.Adds a regression test covering dispatch, values before the subcommand name, and
list --help/help list.