Repository navigation
[CMake] Require CMake 3.29 to enable CMP0157 - #1001
Open
charles-zablit wants to merge 1 commit into
Open
charles-zablit wants to merge 1 commit into
charles-zablit wants to merge 1 commit into
Conversation
7 of 26 tasks
compnerd
suggested changes
Nov 5, 2026
compnerd
left a comment
compnerd
left a comment
Contributor
There was a problem hiding this comment.
This needs rework as mentioned on the other PRs
charles-zablit
force-pushed
the
cz/cmake/cmp0157
branch
from
November 6, 2026 14:17
65955c2 to
ef51aa0
Compare
charles-zablit
changed the title
compnerd
approved these changes
Nov 9, 2026
rauhul
approved these changes
Nov 9, 2026
rauhul
enabled auto-merge (squash)
November 9, 2026 23:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require CMake 3.29, which makes CMP0157 NEW: Ninja compiles each Swift module in its own step, separate from the link. The policy no longer adds
-wmoto optimized builds; the toolchain build passesCMAKE_Swift_COMPILATION_MODEinstead (swiftlang/swift#94066).Tracking: swiftlang/swift#93995
assisted by Claude