feat: enable brotli request compression by default#1052
Open
vdusek wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 91.77% 91.87% +0.10%
==========================================
Files 50 50
Lines 3222 3225 +3
==========================================
+ Hits 2957 2963 +6
+ Misses 265 262 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables brotli compression as the default for all SDK/client ↔ platform communication.
apify-client v3 defaults to
gzip, so enabling brotli takes two parts:apify-client[brotli]extra so the brotli backend is installed. apify-client v3.1 (which adds request body compression) isn't released yet, so this temporarily pins the latest beta that already ships the extra (apify-client[brotli]>=3.0.7b1). ATODOinpyproject.tomltracks switching to>=3.1.0once v3.1 is out.ApifyClientAsync(Actor.new_clientand the storage-client factory_create_api_client) now passcompression='brotli'. Since the SDK hard-depends onapify-client[brotli], the brotli backend is always installed, so brotli is passed directly.Tests: a wire-level test drives a real request through an SDK-created client against a local HTTP server and asserts the body goes out with
Content-Encoding: brand round-trips back throughbrotli.decompress. It's parametrized over both client-creation paths (_create_api_clientandActor.new_client).Closes #1045