TINKERPOP-3238 Throw FailResponseException for fail() step over remote#3460
Open
spmallette wants to merge 1 commit into
Open
TINKERPOP-3238 Throw FailResponseException for fail() step over remote#3460spmallette wants to merge 1 commit into
spmallette wants to merge 1 commit into
Conversation
The Java driver now throws a FailResponseException, a subclass of ResponseException that implements Failure, when the server returns a SERVER_ERROR_FAIL_STEP (595) status code. This makes remote handling of the fail() step more consistent with embedded behavior. Failure.format() is guarded against null traversal/traverser context since that data is not transmitted from the server, preventing a NullPointerException when formatting a remotely-reconstructed Failure. Adds unit tests for both the defensive format() logic and the new exception, plus documentation in the reference and upgrade guides. Assisted-by: Claude Code:claude-opus-4-8
Contributor
we still use ResponseException and could probably do something very similar to what is done here. We don't have that same error code anymore but we do get a "ServerFailStepException" as the exception type in the response so we'd use that as the conditional instead. |
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3238
The Java driver now throws a FailResponseException, a subclass of ResponseException that implements Failure, when the server returns a SERVER_ERROR_FAIL_STEP (595) status code. This makes remote handling of the fail() step more consistent with embedded behavior.
Failure.format() is guarded against null traversal/traverser context since that data is not transmitted from the server, preventing a NullPointerException when formatting a remotely-reconstructed Failure.
Adds unit tests for both the defensive format() logic and the new exception, plus documentation in the reference and upgrade guides.
@kenhuuu could you say what this change means in 4.0? I don't know that we have the same kind of Exception hierarchy there anymore iirc
VOTE +1