Refactor Isolation Forest builtin and add edge-case tests#2498
Draft
PeilinChen01 wants to merge 2 commits into
Draft
Refactor Isolation Forest builtin and add edge-case tests#2498PeilinChen01 wants to merge 2 commits into
PeilinChen01 wants to merge 2 commits into
Conversation
This patch promotes the existing Isolation Forest algorithm implementation from the staging phase to builtin status, with improvements. The implementation provides two main builtins, outlierByIsolationForest for training iForest models and outlierByIsolationForestApply for scoring samples based on trained models. Specifically, we optimized the algorithm with vectorized harmonic number computation for improved scalability. The patch extends test coverage in `staging/isolationForestTest.dml` with comprehensive tests, and Python API integration tests. Refer to JIRA for detailed discussions. Related to apache#1980 Co-authored-by: keremaras1 <60196502+keremaras1@users.noreply.github.com> Co-authored-by: denizzqq <denizdolanmaz@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request contains the midterm progress for the Isolation Forest builtin implementation in SystemDS.
Main changes:
subsampling_sizeto the actual number of input rows when necessary.outlierByIsolationForestApply.Tests
The following command passes locally:
mvn -Dtest=BuiltinIsolationForestTest testCovered test cases include: