Skip to content

[SYSTEMDS-3922] Fix federated quantile VALUEPICK averaging for even-length input #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MegaByteTron wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −8
Open

[SYSTEMDS-3922] Fix federated quantile VALUEPICK averaging for even-length input #2497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/sysds/runtime/instructions/fed/QuantilePickFEDInstruction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public <T> MatrixBlock getEquiHeightBins(ExecutionContext ec, int colID, double[
public <T> void processRowQPick(ExecutionContext ec) {
MatrixObject in = ec.getMatrixObject(input1);
FederationMap fedMap = in.getFedMapping();
boolean average = _type == OperationTypes.MEDIAN;
boolean average = _type == OperationTypes.MEDIAN || _type == OperationTypes.VALUEPICK;

double[] quantiles = input2 != null ? (input2.isMatrix() ? ec.getMatrixInput(input2).getDenseBlockValues() :
input2.isScalar() ? new double[] {ec.getScalarInput(input2).getDoubleValue()} : null) :
Expand Down
7 changes: 0 additions & 7 deletions ...ava/org/apache/sysds/test/functions/federated/primitives/part2/FederatedQuantileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.apache.sysds.test.TestConfiguration;
import org.apache.sysds.test.TestUtils;
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
Expand Down Expand Up @@ -71,19 +70,16 @@ public void setUp() {
}

@Test
@Ignore
public void federatedQuantile1CP() {
federatedQuartile(Types.ExecMode.SINGLE_NODE, TEST_NAME1, 0.25);
}

@Test
@Ignore
public void federatedQuantile2CP() {
federatedQuartile(Types.ExecMode.SINGLE_NODE, TEST_NAME1, 0.5);
}

@Test
@Ignore
public void federatedQuantile3CP() {
federatedQuartile(Types.ExecMode.SINGLE_NODE, TEST_NAME1, 0.75);
}
Expand All @@ -104,19 +100,16 @@ public void federatedQuantilesCP() {
}

@Test
@Ignore
public void federatedQuantile1SP() {
federatedQuartile(Types.ExecMode.SPARK, TEST_NAME1, 0.25);
}

@Test
@Ignore
public void federatedQuantile2SP() {
federatedQuartile(Types.ExecMode.SPARK, TEST_NAME1, 0.5);
}

@Test
@Ignore
public void federatedQuantile3SP() {
federatedQuartile(Types.ExecMode.SPARK, TEST_NAME1, 0.75);
}
Expand Down