[fix][schema] Fix Protobuf native descriptor deserialization - #26725
Open
Denovo1998 wants to merge 1 commit into
Open
Denovo1998 wants to merge 1 commit into
Denovo1998 wants to merge 1 commit into
Conversation
Denovo1998
marked this pull request as ready for review
September 27, 2026 03:56
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ProtobufNativeSchemaUtils.deserialize()fails to resolve nested root messages in files without a package, recurses indefinitely on cyclic imports, and leaves Java feature extensions unrecognized in the reconstructed descriptor proto. This shared utility is used by the default schema checker, broker schema validation, and generic client readers.This is the standalone shared-deserializer prerequisite extracted from #19566. It does not add the advanced compatibility checker or change its activation policy.
Modifications
SchemaSerializationException.Verifying this change
Local validation, with test retries disabled:
./gradlew quickCheckpassed.Does this pull request potentially affect one of the following parts:
Schema descriptor reconstruction changes for all native-schema callers. The stored schema format and message wire format are unchanged.