[fix] [client] chunked message uuid-queue never removes entries on successful processing - #26658
Open
programmerahul wants to merge 6 commits into
Open
programmerahul wants to merge 6 commits into
programmerahul wants to merge 6 commits into
Conversation
Contributor
Author
|
@lhotari Please review |
Contributor
Author
|
The larger issue with this is that , after processing of first chunked message, the expiry mechanism removeExpireIncompleteChunkedMessages() can't work for any incomplete message, because the logic will always find the first uuid from blockingQueue, but not in the chunkedMessageMap. |
Contributor
Author
|
@poorbarcode @void-ptr974 @merlimat @codelipenghui @BewareMyPower @Demogorgon314 please review this PR. This is easily reproducible bug, and as a side-effect of it, the expiry mechanism doesn't work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26676
uuid-queue pendingChunkedMessageUuidQueue doesn't remove entries after a chunked message is processed. So after processing 1M chunked messages, this queue has 1M entries.
This can be reproduced easily by sending chunked message and on consumer end simply acking those. So once the consumer processs 1M message , this queue also reached that size.