Conversation
Signed-off-by: Dream95 <zhou_8621@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26577
Motivation
Window functions ack
ATLEAST_ONCErecords inprocessWindow, after the window fires. A late tuple (timestamp behind the watermark) is not added toWindowManager, so that ack never happens.The message stays unacked, gets redelivered, and can push the consumer toward
maxUnackedMessages.ATMOST_ONCEalready acks at the start ofprocess(), so it is unaffected.Modifications
WindowFunctionExecutor.process()acks late tuples when the guarantee isATLEAST_ONCE.If
lateDataTopicis not set, ack after the existing "will not be processed" log. If it is set, ack inthenAcceptafter the late-data send succeeds. A failed send leaves the record unacked.Verifying this change
This change added tests and can be verified as follows:
testLateTupleAckedWithAtleastOncecovers the no-late-data-topic casetestLateTupleAckedAfterLateDataSendchecks that ack waits for a successful sendtestLateTupleNotAckedWhenLateDataSendFailschecks that a failed send does not ackDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes