[fix][sec] Bump google.golang.org/grpc from 1.83.1 to 1.83.2 in /pulsar-function-go - #26541
Merged
Merged
Conversation
…ar-function-go ### Motivation grpc-go 1.83.2 is a security release: the server now rejects requests missing both the `:authority` and `Host` headers with HTTP 400 and status `Internal` (grpc/grpc-go#9365). Dependabot split this bump into apache#26507 (parent module) and apache#26508 (`examples` module). The `examples` module `replace`s the parent with `../`, so bumping only the parent leaves `examples/go.mod` stale and `go install ./...` in `examples` fails with "updates to go.mod needed", which breaks the `pulsar-test-latest-version` Docker image build. Bumping only `examples` leaves the parent module on 1.83.1. ### Modifications Bump `google.golang.org/grpc` to 1.83.2 in both Go modules in a single change, as was done for the previous bump in apache#26446: cd pulsar-function-go && go get google.golang.org/grpc@v1.83.2 && go mod tidy cd examples && go mod tidy The resulting diff is exactly the union of apache#26507 and apache#26508, including the transitive bumps of golang.org/x/{mod,net,sys,text}. Supersedes apache#26507 and apache#26508.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
grpc-go 1.83.2 is a security release: the server now rejects requests missing both the
:authorityandHostheaders with HTTP 400 and statusInternal(grpc/grpc-go#9365).Dependabot split this bump into #26507 (parent module) and #26508 (
examplesmodule). Theexamplesmodulereplaces the parent with../, so bumping only the parent leavesexamples/go.modstale andgo install ./...inexamplesfails with "updates to go.mod needed", which breaks thepulsar-test-latest-versionDocker image build (that is why #26507 is red). Bumping onlyexamplesleaves the parent module on 1.83.1.Modifications
Bump
google.golang.org/grpcto 1.83.2 in both Go modules in a single change, as was done for the previous bump in #26446:The resulting diff is exactly the union of #26507 and #26508, including the transitive bumps of
golang.org/x/{mod,net,sys,text}.Supersedes #26507 and #26508.
Verifying this change
This change is already covered by existing tests, such as the
CI - Go Functionsworkflow and the Go function integration tests inCI - System - Function.Verified locally:
go mod tidy -diffis a no-op in both modules;go build ./...,go install -mod=readonly ./...inexamples(the Docker image step that fails on #26507),golangci-lint run -c ./golangci.yml ./pf, andgo teston the non-examples packages all pass.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes