Gd32f470vit6 port - #19503
Open
jacksonGreenStone wants to merge 6 commits into
Open
Conversation
- Add FMC_PROGMEM_PAGESIZE 4096 for CONFIG_GD32F4_FLASH_CONFIG_DEFAULT - Fix uClibc++ Make.defs workaround Co-authored-by: openhands <openhands@all-hands.dev>
jacksonGreenStone
requested review from
jerpelea,
simbit18 and
xiaoxiang781216
as code owners
July 22, 2026 14:23
| @@ -47,6 +47,7 @@ | |||
|
|
|||
| # define FMC_PROGMEM_SECTOR_SIZES {_K(128), _K(128)} | |||
| # define FMC_PROGMEM_SECTOR_NUM (2) | |||
| # define FMC_PROGMEM_PAGESIZE 4096 | |||
Contributor
There was a problem hiding this comment.
keep 4096 align with others
Contributor
|
@jacksonGreenStone nice contribution, please read the https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md and fill the PR Summary correctly. Since you adding support to GD32F470VIT6 is could be a good idea to add a board with this chip too. It will allow you and others to validate it easily. This board could be a good fit: https://aliexpress.com/item/1005011968142359.html |
github-actions
Bot
added
Arch: arm
|
linguini1
requested changes
Jul 23, 2026
linguini1
left a comment
linguini1
left a comment
Contributor
There was a problem hiding this comment.
Please follow the contribution guide
Enable GD32F4_APP_FORMAT_MCUBOOT and PROGMEM OTA slot options needed by the board mcuboot-loader/app configurations. Co-authored-by: Cursor <cursoragent@cursor.com>
jacksonGreenStone
requested review from
hartmannathan and
pkarashchenko
as code owners
July 24, 2026 11:00
Point the out-of-tree board symlink at the sibling nuttx_mcu package path.
The RTT syslog channel previously disabled CRLF, so LF-only lines staircased in MobaXterm. Leave sc_state default so CONFIG_SYSLOG_CRLF applies.
acassis
reviewed
Jul 26, 2026
| , SYSLOG_CHANNEL_DISABLE_CRLF | ||
| # endif | ||
| /* sc_state defaults to 0: CRLF conversion ON when CONFIG_SYSLOG_CRLF=y. | ||
| * Needed for MobaXterm / Windows RTT (LF-only causes staircase wrap). |
Contributor
There was a problem hiding this comment.
@jacksonGreenStone did you use AI? RTT (Real Time Trace) has nothing to do with Windows RTT (an accessibility feature of Windows). Please use only "Windows" here
acassis
requested changes
Jul 26, 2026
acassis
left a comment
acassis
left a comment
Contributor
There was a problem hiding this comment.
@jacksonGreenStone please add board Documentation (use the board template)
Port bxCAN-style CAN0 support for Board1 and correct CONSOLE_UART ifdef handling so USART5 registers as /dev/ttyS3 when RTT is console. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.
Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.
For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the
adcexample. Adding a new uORB driver may require that you run
uorb_listenerto verify correct operation.Pure documentation changes can just be tested with
make html(see docs) and verification of the correct format in your
browser.
PRs without testing information will not be accepted. We will
request test logs.