Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25518 +/- ##
==========================================
- Coverage 82.38% 82.38% -0.01%
==========================================
Files 1138 1138
Lines 434313 434313
Branches 434313 434313
==========================================
- Hits 357805 357804 -1
+ Misses 54876 54874 -2
- Partials 21632 21635 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A free
RANGEwindow frame determines peers using everyORDER BYexpression. However, when the first expression had an offset target type, the
analyzer did not validate the remaining expressions.
Consequently, an unsupported trailing
Mapexpression could reach executionand rows with different map values could incorrectly be treated as peers.
What changes are included in this PR?
Validate all trailing
ORDER BYexpressions when the first expressionestablishes the RANGE target type.
This preserves the existing behavior that accepts a
Listas the firstORDER BYexpression, while rejecting unsupported trailing expressions.A SQL logic regression test for
ORDER BY int_col, map_colis included.What is the testing strategy for this PR?
window.slt.code reports a planning error.
Listand supported multi-key cases.cargo fmt --all -- --check.cargo clippy -p datafusion-optimizer --all-targets --all-features -- -D warnings.Are there any user-facing changes?
Yes. Free
RANGEframes with an unsupported trailingORDER BYtype are nowrejected during planning instead of potentially producing incorrect results.
There are no public API changes.