fix: preserve overflow behavior and exhaustively destructure expression proto hooks

[peterxcli]

Which issue does this PR close?

Closes #24614.

Rationale for this change

This PR fixes serialization losing the setting that makes arithmetic fail on overflow. For example, checked Int32::MAX + 1 raises an error before serialization but returns Int32::MIN after decoding. Preserving this setting ensures that sending an expression through protobuf preserves its arithmetic behavior.

What changes are included in this PR?

The protobuf message now stores BinaryExpr::fail_on_overflow, and both supported decoding formats restore it. When the encoder combines nested expressions into a flat list of operands, it requires their operators and overflow settings to match. This preserves the behavior of expressions that mix checked and wrapping arithmetic. The generated Rust and JSON bindings include the new field.

All six encoding and decoding hooks for BinaryExpr, LikeExpr, and SqlSimilarToPattern explicitly list every field without a rest pattern. Adding a field to an expression or its protobuf payload will cause a compile error until the corresponding hook handles it.

The PR also changes the PostgreSQL SQLLogicTest decimal formatter to borrow its argument, resolving an existing Clippy error that blocked the required checks before committing.

What is the testing strategy for this PR?

The new tests serialize and decode nested additions, then check their evaluated results for all four combinations of checked and wrapping arithmetic. The regression test failed before the fix because an expression that should raise an overflow error returned Int32(-2147483648). Additional tests cover older messages that omit the new field and verify that JSON preserves the overflow setting.

All 17 focused expression tests passed. The extended workspace run passed 11,260 Rust tests, with 8 ignored, and completed all 511 SQLLogicTest files. Both conversion tests passed with the PostgreSQL feature enabled. Formatting, Clippy with all targets and features, and the complete ./dev/rust_lint.sh suite also passed.

Are there any user-facing changes?

Expressions configured to fail on arithmetic overflow now raise the expected error after serialization and decoding, including nested expressions with different overflow settings.

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

     Cloning apache/main
    Building datafusion-physical-expr v55.1.0 (current)
       Built [  30.522s] (current)
     Parsing datafusion-physical-expr v55.1.0 (current)
      Parsed [   0.050s] (current)
    Building datafusion-physical-expr v55.1.0 (baseline)
       Built [  30.334s] (baseline)
     Parsing datafusion-physical-expr v55.1.0 (baseline)
      Parsed [   0.051s] (baseline)
    Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.343s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  62.296s] datafusion-physical-expr
    Building datafusion-proto v55.1.0 (current)
       Built [  57.030s] (current)
     Parsing datafusion-proto v55.1.0 (current)
      Parsed [   0.018s] (current)
    Building datafusion-proto v55.1.0 (baseline)
       Built [  56.952s] (baseline)
     Parsing datafusion-proto v55.1.0 (baseline)
      Parsed [   0.019s] (baseline)
    Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.114s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 115.490s] datafusion-proto
    Building datafusion-proto-models v55.1.0 (current)
       Built [  26.776s] (current)
     Parsing datafusion-proto-models v55.1.0 (current)
      Parsed [   0.138s] (current)
    Building datafusion-proto-models v55.1.0 (baseline)
       Built [  26.311s] (baseline)
     Parsing datafusion-proto-models v55.1.0 (baseline)
      Parsed [   0.134s] (baseline)
    Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   1.881s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field ---

Description:
A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field PhysicalBinaryExprNode.fail_on_overflow in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1841
  field PhysicalBinaryExprNode.fail_on_overflow in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1841

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  56.311s] datafusion-proto-models

[codecov-commenter]

Codecov Report

❌ Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.42%. Comparing base (0576a0b) to head (6841655).

Files with missing lines	Patch %	Lines
datafusion/physical-expr/src/expressions/binary.rs	84.84%	1 Missing and 4 partials ⚠️
datafusion/proto-models/src/generated/pbjson.rs	69.23%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #25034      +/-   ##
==========================================
- Coverage   82.42%   82.42%   -0.01%     
==========================================
  Files        1139     1139              
  Lines      435372   435406      +34     
  Branches   435372   435406      +34     
==========================================
+ Hits       358845   358871      +26     
+ Misses      54826    54824       -2     
- Partials    21701    21711      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kosiew]

@peterxcli,

Thanks for working on this. The overflow policy now looks properly preserved across protobuf roundtrips, including cases where flattened binary-expression chains have different overflow policies.

I only have one non-blocking suggestion around JSON coverage.

[kosiew]

Could we also add a JSON roundtrip case for the current flattened operands representation with failOnOverflow: true? Right now this test covers JSON through the legacy l/r shape, while normal encoding emits operands. Covering that form would exercise the updated pbjson handling through the same representation used by current production encoding.

[alamb]

@peterxcli will you have time to address @kosiew 's comments before merging?

[kosiew]

@peterxcli,

Thanks for the follow-up. The new JSON round-trip test addresses the earlier coverage suggestion. It checks the current flattened operands representation, verifies that failOnOverflow is serialized, and confirms that checked overflow behavior is preserved after JSON decoding.

I also checked the merge commit and did not find any additional PR-side changes or new issues.

Looks good to me.