Skip to content

add rabbitmq jasypt property encryption facility#13676

Draft
DaanHoogland wants to merge 1 commit into
apache:4.22from
shapeblue:ghi13352-rabbitmqEncryption
Draft

add rabbitmq jasypt property encryption facility#13676
DaanHoogland wants to merge 1 commit into
apache:4.22from
shapeblue:ghi13352-rabbitmqEncryption

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #13352

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.69%. Comparing base (0339f31) to head (55fb559).

❗ There is a different number of reports uploaded between BASE (0339f31) and HEAD (55fb559). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0339f31) HEAD (55fb559)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.22   #13676       +/-   ##
=============================================
- Coverage     17.69%    3.69%   -14.01%     
=============================================
  Files          5925      449     -5476     
  Lines        533534    38176   -495358     
  Branches      65273     7072    -58201     
=============================================
- Hits          94421     1409    -93012     
+ Misses       428434    36580   -391854     
+ Partials      10679      187    -10492     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
DaanHoogland force-pushed the ghi13352-rabbitmqEncryption branch from 9adf608 to 55fb559 Compare July 24, 2026 10:37
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Spring PropertyPlaceholderConfigurer implementation in utils to decrypt ENC(...)-wrapped property values using a provided Jasypt StringEncryptor, intended to replace the missing/incompatible jasypt-spring3 placeholder configurer referenced in RabbitMQ encryption docs/config.

Changes:

  • Introduces EncryptablePropertyPlaceholderConfigurer to decrypt ENC(...) property values during Spring placeholder resolution.
  • Adds unit tests covering encrypted, whitespace-wrapped encrypted, plain, and null property values.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
utils/src/main/java/com/cloud/utils/crypt/EncryptablePropertyPlaceholderConfigurer.java New Spring placeholder configurer that decrypts ENC(...) values via Jasypt StringEncryptor.
utils/src/test/java/com/cloud/utils/crypt/EncryptablePropertyPlaceholderConfigurerTest.java Unit tests validating decrypt/pass-through/null handling behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +30 to +34
* This replaces {@code org.jasypt.spring3.properties.EncryptablePropertyPlaceholderConfigurer}
* (from the jasypt-spring3 artifact), which is not on the classpath and is incompatible with
* Spring 5, so beans referencing it fail with a ClassNotFoundException.
*/
public class EncryptablePropertyPlaceholderConfigurer extends PropertyPlaceholderConfigurer {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants