ui: Do not send projectid=-1 on the Quota summary page#13658
ui: Do not send projectid=-1 on the Quota summary page#13658winterhazel wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #13658 +/- ##
=============================================
- Coverage 19.64% 3.41% -16.24%
=============================================
Files 6368 487 -5881
Lines 575109 41862 -533247
Branches 70371 7910 -62461
=============================================
- Hits 112994 1429 -111565
+ Misses 449829 40234 -409595
+ Partials 12286 199 -12087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@winterhazel , would it make sense to have the quota summary page not show the project toggle instead? Also, unknown parameters should be gracefully ignored in the API layer, can you show the logging for the call? |
+1 on the second part |
Description
This fixes a minor bug in the Quota UI.
Enabling the projects toggle on any page makes the UI send
projectid=-1to APIs; however, this parameter makes the Quota summary page display an error. This is because a special handling forprojectid=-1was never implemented onquotaSummary, since it already returns entries for the accessible projects ever since it was introduced.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Without the patch, I verified that enabling the projects toggle and switching to the Quota summary page would display an error.
Error when accessing the Quota summary page
Applying these changes allows the Quota summary page to load as intended when repeating the same steps.
Quota summary page loaded successfully