Fix the servicecapabilitylist type for create VPC & Network Offerings#158
Open
Pearl1594 wants to merge 2 commits into
Open
Fix the servicecapabilitylist type for create VPC & Network Offerings#158Pearl1594 wants to merge 2 commits into
Pearl1594 wants to merge 2 commits into
Conversation
added 2 commits
July 23, 2026 14:52
…ix-vpc-offering-service-capability-list
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects how servicecapabilitylist is represented and serialized for the CloudStack createVPCOffering and createNetworkOffering APIs, aligning the generated Go client with the API’s expected indexed object format.
Changes:
- Update code generation overrides so
servicecapabilitylistis treated as a list of maps forcreateVPCOfferingandcreateNetworkOffering. - Adjust request query serialization for
servicecapabilitylistto emitservicecapabilitylist[i].<field>=<value>pairs. - Update the generated params setters/getters to use
[]map[string]stringand addAddServicecapabilitylisthelpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| generate/generate.go | Adds generation overrides so servicecapabilitylist is generated/handled as a list-of-maps for the two affected commands. |
| cloudstack/VPCService.go | Updates CreateVPCOfferingParams type + URL encoding for servicecapabilitylist to indexed list form and adds an Add... helper. |
| cloudstack/NetworkOfferingService.go | Updates CreateNetworkOfferingParams type + URL encoding for servicecapabilitylist to indexed list form and adds an Add... helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.