chore(docs): parameterize RC version in RELEASE.md and add archive prefix - #625
Merged
Merged
Conversation
Introduce AVRO_RC_VERSION variable, use it for the tag, tarball name, and git archive --prefix so the tarball extracts into a top-level directory. Quote variable expansions and guard cd calls per shellcheck.
martin-g
approved these changes
Aug 10, 2026
Kriskras99
approved these changes
Aug 10, 2026
Contributor
|
Can I also suggest (not for this PR) to publish the release candidates on crates.io? |
martin-g
changed the title
Member
Do other projects publish RCs ? Do you have some examples ? |
Contributor
|
Yes, and Cargo has full support for release candidates (it won't auto update to them). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve the release instructions in
RELEASE.md:AVRO_RC_VERSIONvariable (e.g.RC0) and use it for the git tag, tarball name, and SVN upload steps.--prefix=apache-avro-rs-$AVRO_RS_VERSION-$AVRO_RC_VERSION/togit archiveso the tarball extracts into a top-level directory instead of dumping files into the current directory.cdcalls, per shellcheck (SC2086, SC2164).Why
The previous
git archivecommand produced a tarball without a prefix directory, and the RC identifier was hardcoded in several places.