[AMORO-4264][AMS] Use a dedicated thread pool for snapshot expiration planning - #4311
Open
johntomcat7408-cmyk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Snapshot expiration planning uses Iceberg's global worker pool by default. Under load, expiration planning can occupy that shared pool while self-optimizing commits wait for worker futures, leaving tables in the committing state for a long time.
Close #4264.
Brief change log
expire-snapshots.plan-thread-count(default:10) from the Iceberg process factory.ExpireSnapshots.planWith(...).How was this patch tested?
Validated on Linux with both JDK 11 and JDK 17:
./mvnw test \ -pl amoro-ams \ -am \ -Pskip-dashboard-build \ -Dtest=TestIcebergThreadPools,TestIcebergTableMaintainer,TestIcebergProcessFactory,TestSnapshotExpireIceberg \ -Dsurefire.failIfNoSpecifiedTests=falseBoth runs completed with
BUILD SUCCESS. The focused unit tests passed without failures or errors, andTestSnapshotExpireIcebergreported 0 failures and 0 errors.Documentation
process-factories.yaml, and the pool scope and fallback behavior are documented in JavaDocs.