Repository navigation
Conversation
On Windows `srt-win acl stamp` creates a deny target that does not exist yet, so it has something to write the access entry on: missing directories above it as directories, and the path itself as an empty file unless the entry ends in a separator. What it creates stays after the session ends, so a program that later runs `mkdir` there gets EEXIST. The behaviour and the trailing-separator convention were described only in source comments; the README covered the Linux case alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
srt-win acl stampmust create a missingdenyRead/denyWritetarget before it can write the access entry on it. Missing parent directories are created as directories, and the path itself as an empty file unless the entry ends in a separator. These are left on disk after the session ends.Embedders hit this when they deny a directory they only create later. The deny turns it into a zero-byte file, and the embedder's own
mkdirthen fails withEEXISTon every later run. Today this rule and the trailing-separator convention are documented only in source comments (cli.rscanonicalize_ace_targets,path_id.rscreate_placeholder_chain) and in the JSDoc ofexpandWindowsFsPaths; the README covers only the Linux case.This adds a Windows paragraph next to the Linux one. It covers:
EEXISTconsequence, and the two ways to avoid it: a trailing separator, or creating the directory first;Docs only, no behaviour change. The behaviour is already pinned by
test/sandbox/glob-expand.test.ts("preserves trailing separator on passed-through deny") and bypath_id.rsplaceholder_chain_round_trip. I also checked the file and directory cases against thesrt-winbinary.This does not take a side on the open question in #657 (part 2): whether placeholders should be removed on restore, or be opt-out.
Validation:
git diff --check.🤖 Generated with Claude Code